[Crypto][BSSL] Add boringssl based implementation of the crypto interface#32
Merged
[Crypto][BSSL] Add boringssl based implementation of the crypto interface#32
Conversation
timhirsh
previously approved these changes
Jan 9, 2025
Member
timhirsh
left a comment
timhirsh
left a comment
There was a problem hiding this comment.
.github/workflows/cmake-build-and-test.yml LGTM 👍 Deferring to other subject matter experts for the remaining changes.
seidelrj
requested changes
Jan 23, 2025
Contributor
seidelrj
left a comment
seidelrj
left a comment
There was a problem hiding this comment.
just 1 copyright to fix.
seidelrj
approved these changes
Jan 23, 2025
timhirsh
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a reference implementation of the nat20 crypto interface based on boringssl. It also instantiates the crypto test and runs it against the implementation.