Make globalcontext_make_atom safe#1443
Draft
bettio wants to merge 2 commits intoatomvm:mainfrom
Draft
Conversation
globalcontext_make_atom may allocate memory, and that operation might fail. In that situation now the function returns an invalid term that must be checked (so an out of memory error can be raised). Signed-off-by: Davide Bettio <davide@uninstall.it>
Add macro that raises an error when there is an out of memory while making an atom, otherwise a term with given name is declared and available. Signed-off-by: Davide Bettio <davide@uninstall.it>
UncleGrumpy
reviewed
Dec 29, 2024
| #define REQUIRE_ATOM(name, lenstr, str, glb) \ | ||
| term name = globalcontext_make_atom(glb, lenstr str); \ | ||
| if (UNLIKELY(term_is_invalid_term(name))) { \ | ||
| RAISE_ERROR(OUT_OF_MEMORY_ATOM); \ |
Collaborator
There was a problem hiding this comment.
This is perfect for nifs, but doesn’t cover porta. Maybe we need a separate macro for use in ports that would just return the out_of_memory atom? Ideally it would be {error, out_of_memory} (for ports), but in this case it would be unlikely there was enough ram to construct the error tuple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also: #1442
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later