Skip to content

increasing timeout for v3 integration tests to 20min#1022

Merged
vykimnguyen merged 1 commit intomainfrom
increase-v3-integration-test-timeout
Feb 12, 2026
Merged

increasing timeout for v3 integration tests to 20min#1022
vykimnguyen merged 1 commit intomainfrom
increase-v3-integration-test-timeout

Conversation

@vykimnguyen
Copy link
Contributor

@vykimnguyen vykimnguyen commented Feb 12, 2026

Motivation

I've found that the Integration tests (v3 macos-15, Node 24) pipelines are often getting cancelled at ~15 minutes which aligns with our current timeout for v3. When they do pass, they run for just under 15min (example 1, example 2)

Changes

  • Increasing job timeout to 20min to hopefully reduce build cancellations.

Checklist

  • Existing or new tests cover this change
  • There is a changeset for this change, or one is not required
  • Added documentation for any new features to the docs/ folder

@vykimnguyen vykimnguyen requested a review from a team as a code owner February 12, 2026 02:34
@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2026

⚠️ No Changeset found

Latest commit: 35b4b92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

📊 Type Coverage Report

Coverage Comparison

Metric Baseline Current Change
Coverage Percentage 92.26% 92.26% ➡️ 0.00%
Correctly Typed 220,731 220,731 +0
Total Expressions 239,225 239,225 +0
Untyped Expressions 18,494 18,494 +0

Files with Most Type Issues (Top 15)

File Issues Affected Lines
packages/core/integration-tests/test/javascript.ts 1152 745
packages/core/integration-tests/test/cache.ts 885 626
packages/core/integration-tests/test/scope-hoisting.ts 622 489
packages/utils/node-resolver-core/test/resolver.ts 476 177
packages/core/integration-tests/test/html.ts 468 294
packages/core/integration-tests/test/sourcemaps.ts 356 176
packages/core/test-utils/src/utils.ts 330 205
packages/core/integration-tests/test/incremental-bundling.ts 298 206
packages/core/core/src/dumpGraphToGraphViz.ts 251 108
packages/core/integration-tests/test/transpilation.ts 230 139
packages/core/integration-tests/test/output-formats.ts 227 161
packages/transformers/webextension/src/WebExtensionTransformer.ts 210 80
packages/core/core/src/requests/BundleGraphRequestRust.ts 194 67
packages/core/integration-tests/test/css-modules.ts 191 107
packages/core/core/src/requests/TargetRequest.ts 190 133

This report was generated by the Type Coverage GitHub Action

name: Integration tests (v3 ${{ matrix.os }}, Node ${{ matrix.node }})
needs:
- build_native
timeout-minutes: 15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true even with slices? That is, the slices are pushing this timeout?

Also though, from the timestamps I've seen during cancellation, the Cancelled is often minutes after the last log line - so I still think the tests hang before they get cancelled. I guess we'll see if they still get cancelled at 20m now or if this helps! 🤞

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen cancelled slices at 15min, but its possible for the tests to still be hanging. Let's see if increasing the timeout will help at all

@vykimnguyen vykimnguyen merged commit bd12764 into main Feb 12, 2026
43 of 49 checks passed
@vykimnguyen vykimnguyen deleted the increase-v3-integration-test-timeout branch February 12, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants