Resolve file selection bug and standardize backdrop closing #518
+4
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix issue where clicking files in the Command Bar (Ctrl+P) would close the overlay without opening the file by removing a buggy `mousedown` listener. - Standardize the `onClose` behavior for Command Bar, Theme Selector, Icon Theme Selector, and Vim Command Bar. - Enable closing these overlays by clicking the background backdrop, ensuring UI consistency across all command-style components.
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical race condition bug in the Command Bar that prevented file selection via mouse clicks, and standardizes backdrop closing behavior across all command-style overlays.
Changes:
- Fixed the Command Bar file selection bug by removing a problematic
mousedownlistener that was closing the component before file item clicks could register - Enabled backdrop click-to-close functionality for Command Bar, Theme Selector, Icon Theme Selector, and Vim Command Bar by passing the
onCloseprop to theCommandcomponent
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/features/command-bar/hooks/use-command-bar.ts | Removed manual mousedown listener that was causing the race condition |
| src/features/command-bar/components/command-bar.tsx | Added onClose prop to enable backdrop closing |
| src/features/command-palette/components/theme-selector.tsx | Added onClose prop to enable backdrop closing |
| src/features/command-palette/components/icon-theme-selector.tsx | Added onClose prop to enable backdrop closing |
| src/features/vim/components/vim-command-bar.tsx | Added onClose prop to enable backdrop closing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
The root cause of the file selection failure was a manual mousedown listener in useCommandBar.ts that lacked a proper data-command-bar reference. This caused the component to unmount before the onClick event could fire on file items. By removing this manual listener and leveraging the onClose callback built into the Command component's backdrop, we achieve both reliable file opening and intuitive "click outside" behavior.
Additionally, several other command-style overlays were using the Command layout but not passing the onClose callback, preventing users from closing them via background clicks. These have now been aligned for a more consistent UX.
Testing
Related Issues
Fixes #517