add points breakdown table and fix animation bugs#87
Merged
ashworks1706 merged 14 commits intomainfrom Mar 7, 2026
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ben Juntilla <ben@benjuntilla.com>
Signed-off-by: Ash Srivastava <85481905+ashworks1706@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shop UI to make the points breakdown more accessible and refreshes some shop/points content presentation.
Changes:
- Add a floating Points drawer (with a reusable points breakdown table) to all
/shop/*pages viaShopLayout. - Update the shop hero carousel layout and add support for a configurable background video URL.
- Simplify the points system page breakdown table and tweak shop category section visuals/layout.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/Shop/ShopIndex.tsx | Passes a videoUrl into ProductCarousel and adjusts hero section overflow behavior. |
| src/pages/PointsSystem.tsx | Replaces the markdown points breakdown with a smaller “event type” table. |
| src/components/Shop/ShopLayout.tsx | Injects PointsDrawer into all shop routes. |
| src/components/Shop/ProductCarousel.tsx | Adds rightPanel support, changes layout, adds viewport-resize logic, and changes default videoUrl. |
| src/components/Shop/PointsDrawer.tsx | New floating drawer component for points breakdown (desktop hover + mobile button UI). |
| src/components/Shop/PointsBreakdownTable.tsx | New table component used by the drawer. |
| src/components/Shop/CategorySection.tsx | Removes hover-only reveal behavior for product cards, adjusts title sizing, and adds a static section title. |
Comments suppressed due to low confidence (1)
src/components/Shop/CategorySection.tsx:166
- This comment says product cards are “hover on desktop”, but the updated container no longer applies the
md:opacity-0 md:group-hover:opacity-100behavior (cards are always visible on desktop now). Update the comment to match the new behavior (or reintroduce the hover-only classes if that’s still intended).
{/* Product Cards - Always visible on mobile, hover on desktop */}
<div className="relative z-10 p-3 md:p-4 lg:p-6 h-full pt-14 md:pt-14 lg:pt-16">
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ash Srivastava <85481905+ashworks1706@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ash Srivastava <85481905+ashworks1706@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ash Srivastava <85481905+ashworks1706@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ash Srivastava <85481905+ashworks1706@users.noreply.github.com>
Contributor
Author
|
@copilot apply the suggestions. |
Contributor
|
@ashworks1706 I've opened a new pull request, #88, to work on those changes. Once the pull request is ready, I'll request review from you. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
You can also share your feedback on Copilot code review. Take the survey.
…88) * Initial plan * fix: add scope=col to th headers, fix PointsDrawer pin/hover/keyboard UX, remove unused import Co-authored-by: ashworks1706 <85481905+ashworks1706@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ashworks1706 <85481905+ashworks1706@users.noreply.github.com>
Contributor
Author
|
@SachinVenugopalan30 please stamp this |
ashworks1706
changed the title
Contributor
Author
|
done |
Member
|
edited title to have action verbs |
benjuntilla
changed the title
benjuntilla
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.