Skip to content

Commit that shit v2#85

Merged
ashworks1706 merged 8 commits intomainfrom
commit-that-shit-v2
Mar 7, 2026
Merged

Commit that shit v2#85
ashworks1706 merged 8 commits intomainfrom
commit-that-shit-v2

Conversation

@ashworks1706
Copy link
Contributor

No description provided.

ashworks1706 and others added 4 commits February 17, 2026 17:32
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Ben Juntilla <ben@benjuntilla.com>
Copilot AI review requested due to automatic review settings February 18, 2026 01:05
@ashworks1706 ashworks1706 requested a review from a team as a code owner February 18, 2026 01:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an informational points breakdown panel to the Shop landing page hero carousel and adjusts Shop UI layout to better accommodate the new content.

Changes:

  • Add PointsBreakdownTable and render it as an optional rightPanel in ProductCarousel.
  • Update ProductCarousel layout/animations to support a two-column (text + panel) hero section.
  • Adjust CategorySection visuals (title sizing, spacing, and a new static section title overlay).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/pages/Shop/ShopIndex.tsx Injects the points breakdown table into the hero carousel via the new rightPanel prop.
src/components/Shop/ProductCarousel.tsx Adds rightPanel support and updates responsive layout/animation behavior.
src/components/Shop/PointsBreakdownTable.tsx New component rendering a points breakdown table for the Shop hero panel.
src/components/Shop/CategorySection.tsx Removes hover state logic and revises sizing/spacing + adds a static title overlay.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Ash Srivastava <85481905+ashworks1706@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 6, 2026 18:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.


You can also share your feedback on Copilot code review. Take the survey.

@ashworks1706 ashworks1706 enabled auto-merge (squash) March 6, 2026 19:08
@ashworks1706 ashworks1706 self-assigned this Mar 6, 2026
@ashworks1706 ashworks1706 added the bug Something isn't working label Mar 6, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Ash Srivastava <85481905+ashworks1706@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 7, 2026 00:09
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Ash Srivastava <85481905+ashworks1706@users.noreply.github.com>
@ashworks1706 ashworks1706 merged commit ed08c61 into main Mar 7, 2026
4 of 5 checks passed
@ashworks1706 ashworks1706 deleted the commit-that-shit-v2 branch March 7, 2026 00:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


You can also share your feedback on Copilot code review. Take the survey.

Comment on lines +27 to +32
const [isMobile, setIsMobile] = useState(() => window.innerWidth < 1024);

useEffect(() => {
const handleResize = () => setIsMobile(window.innerWidth < 1024);
window.addEventListener("resize", handleResize);
return () => window.removeEventListener("resize", handleResize);
Copy link

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isMobile is initialized by reading window.innerWidth during render. This will throw in any non-browser runtime (e.g., SSR/prerendering or node-based tooling). Consider guarding with typeof window !== "undefined" (or initializing to a safe default and setting it inside useEffect/matchMedia).

Suggested change
const [isMobile, setIsMobile] = useState(() => window.innerWidth < 1024);
useEffect(() => {
const handleResize = () => setIsMobile(window.innerWidth < 1024);
window.addEventListener("resize", handleResize);
return () => window.removeEventListener("resize", handleResize);
const [isMobile, setIsMobile] = useState(false);
useEffect(() => {
if (typeof window === "undefined") {
return;
}
const handleResize = () => setIsMobile(window.innerWidth < 1024);
// Set initial value on mount in the browser
handleResize();
window.addEventListener("resize", handleResize);
return () => {
window.removeEventListener("resize", handleResize);
};

Copilot uses AI. Check for mistakes.
Comment on lines +44 to +54
<table className="w-full text-sm border-collapse">
<caption className="sr-only">
Points breakdown by category, activity, and points
</caption>
<thead>
<tr className="bg-white/[0.06]">
<th
scope="col"
className="text-left px-3 py-2.5 text-gray-400 font-semibold uppercase tracking-widest text-[10px] border-b border-r border-white/10 w-[24%]"
>
Category
Copy link

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better table accessibility, consider adding an (sr-only) <caption> describing the table and using scope="col" on the header cells so screen readers can correctly associate headers with data cells.

Copilot uses AI. Check for mistakes.
Comment on lines +59 to +63
>
Activity
</th>
<th
scope="col"
Copy link

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table rows use an index-based key (${ci}-${ri}), which can lead to unnecessary remounts if categories/rows are reordered. Prefer a stable key derived from the data (e.g., cat.label + row.activity, or add an explicit id).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants