Skip to content

commit that shit#84

Merged
benjuntilla merged 3 commits intomainfrom
commit-that-shit
Feb 18, 2026
Merged

commit that shit#84
benjuntilla merged 3 commits intomainfrom
commit-that-shit

Conversation

@ashworks1706
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 18, 2026 00:33
@ashworks1706 ashworks1706 requested a review from a team as a code owner February 18, 2026 00:33
@ashworks1706 ashworks1706 self-assigned this Feb 18, 2026
@ashworks1706 ashworks1706 added the bug Something isn't working label Feb 18, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Shop category section UI/interaction by simplifying hover-driven behavior and adding a persistent section title.

Changes:

  • Removed hover state management and the hover-based scroll speed change for the background title animation.
  • Added a static section title pinned to the top of the category card.
  • Made product cards always visible on desktop (removed hover/opacity gating).
Comments suppressed due to low confidence (1)

src/components/Shop/CategorySection.tsx:146

  • The background scrolling title appears to be decorative, but it’s rendered as repeated

    text without being hidden from assistive tech. This can cause screen readers to announce the title many times (and now there’s also a visible title at the top). Mark this decorative block as aria-hidden (or otherwise exclude it from the accessibility tree).

      {/* Background Title - Only render animation when in view */}
      {isInView && (
        <motion.div
          ref={scrollRef}
          className={`absolute inset-0 flex ${orientation === "vertical" ? "flex-col justify-center" : "items-center"} overflow-hidden pointer-events-none group-hover:opacity-10 transition-opacity duration-300 ease-in-out will-change-[opacity]`}
          initial={{ opacity: 0 }}
          animate={{ opacity: 0.3 }}
          exit={{ opacity: 0 }}
          transition={{ delay: 0.6, duration: 0.5 }}
          style={
            {
              transform: "translateZ(0)",
              backfaceVisibility: "hidden" as const,
            } as React.CSSProperties
          }
        >
          <div
            className={`${getScrollClass()} whitespace-nowrap flex ${orientation === "vertical" ? "flex-col" : ""}`}
            style={{
              transform: "translateZ(0)",
              willChange: "transform",
            }}
          >
            <h2 className={getTextClass()}>
              {title.toUpperCase()} {title.toUpperCase()} {title.toUpperCase()}{" "}
              {title.toUpperCase()} {title.toUpperCase()} {title.toUpperCase()}
            </h2>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Ben Juntilla <ben@benjuntilla.com>
Copilot AI review requested due to automatic review settings February 18, 2026 00:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@benjuntilla benjuntilla enabled auto-merge (squash) February 18, 2026 00:36
@benjuntilla benjuntilla merged commit 926c65e into main Feb 18, 2026
5 checks passed
@benjuntilla benjuntilla deleted the commit-that-shit branch February 18, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants