-
-
Notifications
You must be signed in to change notification settings - Fork 432
Add ESO catalogue functions #3531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ashleythomasbarnes
wants to merge
13
commits into
astropy:main
Choose a base branch
from
eso:develop-catalogues
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+953
−36
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d194817
Add ESO catalogue functions (#8)
ashleythomasbarnes 5787caa
revert test_eso_remote and remove site_packages
ashleythomasbarnes 22c1cfa
revert eso core formatting
ashleythomasbarnes 8c86e56
putback catalogue query
ashleythomasbarnes b09b19e
minor change
ashleythomasbarnes 81d609c
code style updates
ashleythomasbarnes fdd6ca1
more code style updates
ashleythomasbarnes 800de4a
updated changes.rst with PR #
ashleythomasbarnes 0810201
test fixes
ashleythomasbarnes 8f0d0de
test fixes
ashleythomasbarnes caefff0
test fixes
ashleythomasbarnes 858c58b
test fixes
ashleythomasbarnes db96c8b
test fixes
ashleythomasbarnes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,16 +9,21 @@ class Conf(_config.ConfigNamespace): | |
| """ | ||
| Configuration parameters for `astroquery.eso`. | ||
| """ | ||
|
|
||
| MAX_ROW_LIMIT = _config.ConfigItem( | ||
| 15000000, | ||
| 'Maximum number of rows allowed by the TAP service.') | ||
| ROW_LIMIT = _config.ConfigItem( | ||
| 1000, | ||
| 'Maximum number of rows returned (set to -1 for unlimited).') | ||
| 'Maximum number of rows returned (set to -1 for maximum allowed via TAP service).') | ||
| username = _config.ConfigItem( | ||
| "", | ||
| 'Optional default username for ESO archive.') | ||
| tap_url = _config.ConfigItem( | ||
| tap_obs_url = _config.ConfigItem( | ||
|
Comment on lines
-19
to
+21
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is technically an API change; but for now it is acceptable as we haven't yet released the ESO refactor work. |
||
| "https://archive.eso.org/tap_obs", | ||
| 'URL for TAP queries.') | ||
| 'URL for TAP observation queries.') | ||
| tap_cat_url = _config.ConfigItem( | ||
| "https://archive.eso.org/tap_cat", | ||
| 'URL for TAP catalogue queries.') | ||
|
|
||
|
|
||
| conf = Conf() | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I seem to remember that this file is normally edited by the astroquery maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this is correct, preferably the changelog entry is added in the PR by the PR author.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you need more here...