Open
Conversation
ManonMarchand
force-pushed
the
simbad-add-extra-user-agent
branch
from
3872959 to
11869e1
Compare
ManonMarchand
force-pushed
the
simbad-add-extra-user-agent
branch
from
11869e1 to
780ec6f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3529 +/- ##
=======================================
Coverage 72.71% 72.71%
=======================================
Files 219 219
Lines 20473 20473
=======================================
Hits 14886 14886
Misses 5587 5587 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bsipocz
approved these changes
Feb 12, 2026
Member
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
Looks good, some very minor word-smithing comments
Comment on lines
+870
to
+871
| To declare who you are to the SIMBAD's servers, add an extra **user agent** to your | ||
| SIMBAD instance: |
Member
There was a problem hiding this comment.
Maybe add one more sentence why anyone want to do this?
| simbad | ||
| ~~~~~~ | ||
|
|
||
| - Add the possibility to declare more user agents to ``SimbadClass`` [#3529] |
Member
There was a problem hiding this comment.
Suggested change
| - Add the possibility to declare more user agents to ``SimbadClass`` [#3529] | |
| - Add the possibility to declare more information in the HTTP User-Agent header in ``SimbadClass`` [#3529] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This is a follow up PR of #3526
It adds the
extra_user_agentargument toSimbadClass(just notifying @aoberto 🙂 )