EUCLID: new method get_sia to access the Simple Image Access Protocol (SIAP) v2.0#3506
Conversation
7096526 to
f9d15be
Compare
66e4f21 to
28a7906
Compare
|
This looks like a great addition. Could you clarify - does the get_cutout function currently work with an older siap version? Or does it not work at all? |
|
Also the current test failures look like they're caused by incomplete monkeypatching of the remote queries; something is still reaching out to the internet - but I think that's what you're actively debugging as I type. |
f0c4114 to
ef64478
Compare
The get_sia + get_cutout can be seen as analogous to the datalink service, where the get_links (get_sia) serves as the discovery component, and the get_data (get_cutout) acts as the downloading component. |
e22bd68 to
73dd240
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3506 +/- ##
==========================================
+ Coverage 72.67% 72.71% +0.03%
==========================================
Files 219 219
Lines 20485 20547 +62
==========================================
+ Hits 14887 14940 +53
- Misses 5598 5607 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1204081 to
9552290
Compare
9552290 to
4b78397
Compare
|
Hi team, we have planned to make new changes in the Euclid module in our next sprint, but we would need to complete this task beforehand. Do you need us to make any other thing related to this PR? |
Dear astroquery team,
we would like to implement a new method for the Simple Image Access Protocol (SIAP) v2.0 exposed by the Euclid project.
The Euclid Archive applies the following IVOA standard to serve:
The new get_sia method will allow users to obtain the “file_name” and “file_path” of the FITS files that contain the observations of the input coordinates.
cc @esdc-esac-esa-int
jira: EUCLIDSWRQ-250