FIX: incorrect parameter for JPL Horizons, changed 'BODY EQUATOR' -> 'BODY'#3370
Open
TheWand3rer wants to merge 2 commits intoastropy:mainfrom
Open
FIX: incorrect parameter for JPL Horizons, changed 'BODY EQUATOR' -> 'BODY'#3370TheWand3rer wants to merge 2 commits intoastropy:mainfrom
TheWand3rer wants to merge 2 commits intoastropy:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3370 +/- ##
=======================================
Coverage 70.07% 70.07%
=======================================
Files 232 232
Lines 19893 19893
=======================================
Hits 13940 13940
Misses 5953 5953 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks, this fix looks good to me. As a side note, I thought that quoting "BODY EQUATOR" would fix the problem too, but it resulted in the same error, so this could be a Horizons bug or problem with their documentation. Regardless, the documentation does say that abbreviations are allowed, so I think this fix is correct. @TheWand3rer Please add a change log entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When querying the results of a JPL Horizons query via
elements(refplane='body')the API returns this error:By changing the line in
core.pyfromBODY EQUATORtoBODY, that API call works again.