feat: add use_constants option to disable real constants#576
Open
MilesCranmerBot wants to merge 3 commits intoastroautomata:masterfrom
Open
feat: add use_constants option to disable real constants#576MilesCranmerBot wants to merge 3 commits intoastroautomata:masterfrom
MilesCranmerBot wants to merge 3 commits intoastroautomata:masterfrom
Conversation
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #576 +/- ##
==========================================
- Coverage 94.97% 94.77% -0.21%
==========================================
Files 42 42
Lines 3883 3904 +21
==========================================
+ Hits 3688 3700 +12
- Misses 195 204 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use_constants(defaulttrue) to backendOptionsuse_constants=false, random leaf generation no longer creates real-valued constantsshould_optimize_constants = falseprobability_negate_constant = 0.0mutate_constantandoptimizeforced to0.0use_constantsin warm-start incompatibility checksValidation
TEST_GROUP=unit/basic julia --project=test test/runtests.jl