Skip to content

CompatHelper: bump compat for Optim to 2#561

Open
MilesCranmerBot wants to merge 12 commits intoastroautomata:masterfrom
MilesCranmerBot:optim-compat-2-rebased-20260212
Open

CompatHelper: bump compat for Optim to 2#561
MilesCranmerBot wants to merge 12 commits intoastroautomata:masterfrom
MilesCranmerBot:optim-compat-2-rebased-20260212

Conversation

@MilesCranmerBot
Copy link
Copy Markdown
Contributor

This is a clean rebase of #534 onto current master (minimal diff; no Manifest changes).

Change: allow Optim v2 in [compat].

Supersedes: #534.

@MilesCranmer
Copy link
Copy Markdown
Collaborator

@MilesCranmerBot I think you will need to update some of the code to work with the new Optim. See how this is done in DynamicExpressions.jl.

It would also be good if like DynamicExpressions.jl, we have a forced Optim v1 test to ensure AD-based constant optimization still works on older versions.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 12, 2026

Benchmark Results (Julia v1)

Time benchmarks
master c69a997... master / c69a997...
search/multithreading 15.5 ± 0.23 s 15.4 ± 0.25 s 1.01 ± 0.022
search/serial 33.4 ± 1.2 s 33.7 ± 0.072 s 0.992 ± 0.036
utils/best_of_sample 1.74 ± 0.48 μs 1.98 ± 0.54 μs 0.879 ± 0.34
utils/check_constraints_x10 16.7 ± 4.2 μs 17 ± 4.4 μs 0.981 ± 0.36
utils/compute_complexity_x10/Float64 2.16 ± 0.09 μs 2.15 ± 0.09 μs 1 ± 0.059
utils/compute_complexity_x10/Int64 2.08 ± 0.08 μs 2.09 ± 0.09 μs 0.995 ± 0.057
utils/compute_complexity_x10/nothing 1.53 ± 0.09 μs 1.53 ± 0.081 μs 1 ± 0.079
utils/insert_random_op_x10 5.23 ± 1.7 μs 5.31 ± 1.6 μs 0.985 ± 0.44
utils/next_generation_x100 0.442 ± 0.025 ms 0.44 ± 0.025 ms 1.01 ± 0.08
utils/optimize_constants_x10 0.0347 ± 0.0081 s 0.0366 ± 0.0078 s 0.948 ± 0.3
utils/randomly_rotate_tree_x10 8.25 ± 0.96 μs 8.31 ± 0.96 μs 0.993 ± 0.16
time_to_load 2.62 ± 0.036 s 2.43 ± 0.014 s 1.08 ± 0.016
Memory benchmarks
master c69a997... master / c69a997...
search/multithreading 0.205 G allocs: 53.3 GB 0.205 G allocs: 52.9 GB 1.01
search/serial 0.207 G allocs: 53.8 GB 0.207 G allocs: 53.9 GB 0.997
utils/best_of_sample 0.038 k allocs: 3.25 kB 0.038 k allocs: 3.25 kB 1
utils/check_constraints_x10 0.034 k allocs: 0.875 kB 0.034 k allocs: 0.875 kB 1
utils/compute_complexity_x10/Float64 0 allocs: 0 B 0 allocs: 0 B
utils/compute_complexity_x10/Int64 0 allocs: 0 B 0 allocs: 0 B
utils/compute_complexity_x10/nothing 0 allocs: 0 B 0 allocs: 0 B
utils/insert_random_op_x10 0.041 k allocs: 1.62 kB 0.045 k allocs: 1.88 kB 0.867
utils/next_generation_x100 4.63 k allocs: 0.276 MB 4.62 k allocs: 0.276 MB 1
utils/optimize_constants_x10 25 k allocs: 25.7 MB 26.6 k allocs: 28.6 MB 0.898
utils/randomly_rotate_tree_x10 0.042 k allocs: 1.34 kB 0.042 k allocs: 1.34 kB 1
time_to_load 0.145 k allocs: 11 kB 0.145 k allocs: 11 kB 1

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.02%. Comparing base (2f8a7ac) to head (830bb27).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #561   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files          42       42           
  Lines        3882     3882           
=======================================
  Hits         3689     3689           
  Misses        193      193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants