CompatHelper: bump compat for Optim to 2#561
Open
MilesCranmerBot wants to merge 12 commits intoastroautomata:masterfrom
Open
CompatHelper: bump compat for Optim to 2#561MilesCranmerBot wants to merge 12 commits intoastroautomata:masterfrom
MilesCranmerBot wants to merge 12 commits intoastroautomata:masterfrom
Conversation
(cherry picked from commit 633f828)
Collaborator
|
@MilesCranmerBot I think you will need to update some of the code to work with the new Optim. See how this is done in DynamicExpressions.jl. It would also be good if like DynamicExpressions.jl, we have a forced Optim v1 test to ensure AD-based constant optimization still works on older versions. |
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #561 +/- ##
=======================================
Coverage 95.02% 95.02%
=======================================
Files 42 42
Lines 3882 3882
=======================================
Hits 3689 3689
Misses 193 193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
This reverts commit f2e5e7b.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a clean rebase of #534 onto current
master(minimal diff; no Manifest changes).Change: allow Optim v2 in
[compat].Supersedes: #534.