slightly loosen ProgressMeter compat#487
Open
oscardssmith wants to merge 1 commit intoastroautomata:masterfrom
Open
slightly loosen ProgressMeter compat#487oscardssmith wants to merge 1 commit intoastroautomata:masterfrom
oscardssmith wants to merge 1 commit intoastroautomata:masterfrom
Conversation
We want to avoid 1.10.3, but I don't think there is a strong reason to prevent future patch releases.
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Collaborator
|
Unfortunately ProgressMeter.jl does not follow SemVer: https://github.com/timholy/ProgressMeter.jl/releases/tag/v1.10.1 (multiple features added on a patch release) so I think we should treat every patch release as breaking. Especially since it's such a key dependency in both SymbolicRegression.jl and PySR, I really don't think we can afford such a risk. |
Author
|
@timholy would it be possible for ProgressMeter to more closely semver things? (specifically making minor releases for new features). |
Contributor
Contributor
|
@MarcMush (new features should use a minor version bump) |
|
(just to clarify I'm not a maintainer of ProgressMeter, just a drive-by contributor 😛 ) |
|
@timholy yes I will be more careful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to avoid 1.10.3, but I don't think there is a strong reason to prevent future patch releases.