Ensure all parent level dirs are created in the tar file#104
Open
bbetter173 wants to merge 1 commit intoaspect-build:mainfrom
Open
Ensure all parent level dirs are created in the tar file#104bbetter173 wants to merge 1 commit intoaspect-build:mainfrom
bbetter173 wants to merge 1 commit intoaspect-build:mainfrom
Conversation
|
|
Member
|
Maybe this awk program illustrates a better way to do this? https://github.com/bazel-contrib/tar.bzl/blob/341d46905dd918fd35e50cab75df7289546ab1a5/tar/private/modify_mtree.awk#L102 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
_py_lambda_tar_implfunction inaws/private/py_lambda.bzlto ensure all parent directories are explicitly created when generating themtreespecification.Fixes #103
Key Changes:
Directory Management Enhancements:
_get_parent_dirsto compute all parent directories of a given path. This ensures that directory hierarchies are correctly identified.created_dirsset to track already-created directories, preventing duplicate entries in themtreelist._ensure_parent_dirs, ensuring all parent directories for files and directories are correctly handled.Changes are visible to end-users: no
Test plan
Confirm that the resulting tar archive has all directories added using
tar tf <tar_file>. Compare against previous versions.Note: I am not experienced in Bazel and there may be better ways to achieve the same result. I'm happy to make some small changes if requested but not overly motivated to dig much further.