Better spans for #[filter_fn]#655
Merged
GuillaumeGomez merged 1 commit intoaskama-rs:mainfrom Dec 30, 2025
Merged
Conversation
This way any offending lines in the function signature or body are highlighted instead of the `#[filter_fn]` attribute.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // Checks that `clippy::elidable_lifetime_names` is not triggered. | ||
| /// Checks that `clippy::unnecessary_wraps` is not triggered. | ||
| #[cfg(any())] // FIXME: <https://github.com/askama-rs/askama/issues/651> |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note test
GuillaumeGomez
approved these changes
Dec 30, 2025
Collaborator
|
That's such a weird trick. ^^' Thanks a lot! |
Member
Author
|
I guess clippy looks at specific tokens in the declaration of function, and if they are generated, it guesses everything is generated? A speed-up thing? |
Collaborator
|
Yeah that's not great and seems very brittle. Might be worth opening an issue there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way any offending lines in the function signature or body are highlighted instead of the
#[filter_fn]attribute.Remove the line
#[cfg(any())]to test the output.