fix(derive): use call_site to avoid linter false positives#647
Merged
GuillaumeGomez merged 2 commits intoaskama-rs:mainfrom Dec 25, 2025
Merged
fix(derive): use call_site to avoid linter false positives#647GuillaumeGomez merged 2 commits intoaskama-rs:mainfrom
GuillaumeGomez merged 2 commits intoaskama-rs:mainfrom
Conversation
GuillaumeGomez
previously approved these changes
Dec 25, 2025
Contributor
Author
|
seems like |
ymelois
force-pushed
the
fix/643/use-mixed-site
branch
from
ec261ed to
e3cb26d
Compare
ymelois
changed the title
Implements the suggestion from askama-rs#643 (comment) by using `Span::call_site()`.
Applied call-site spans to generated impl headers/targets, fixing askama-rs#642.
ymelois
force-pushed
the
fix/643/use-mixed-site
branch
from
e3cb26d to
18165d0
Compare
GuillaumeGomez
approved these changes
Dec 25, 2025
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the suggestion from #643 (comment) by using
Span::call_site().Applied call-site spans to generated impl headers/targets, fixing #642.
Fixes #642
Fixes #643