Improve macro call arguments mismatch errors#325
Merged
Kijewski merged 2 commits intoaskama-rs:masterfrom Feb 4, 2025
Merged
Conversation
Member
|
Could you please add two tests in
|
5a7213e to
0454bfb
Compare
Collaborator
Author
|
Sure, done! |
Member
|
I think sometimes the wrong argument name was printed. Can you please verify if my change gets it right? |
Member
|
The PR needs rebasing, then the formatting error should be gone. I didn't do the rebase, so my change to your PR remains legible. |
Collaborator
Author
|
Forgot to check, let me get back to it. |
06f69ae to
8ca9f97
Compare
Collaborator
Author
|
Looks all good to me, thanks! I cannot approve my own PR though. 😅 |
Kijewski
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323.