Skip to content

Improve macro call arguments mismatch errors#325

Merged
Kijewski merged 2 commits intoaskama-rs:masterfrom
GuillaumeGomez:macro-call-args
Feb 4, 2025
Merged

Improve macro call arguments mismatch errors#325
Kijewski merged 2 commits intoaskama-rs:masterfrom
GuillaumeGomez:macro-call-args

Conversation

@GuillaumeGomez
Copy link
Copy Markdown
Collaborator

Fixes #323.

@Kijewski
Copy link
Copy Markdown
Member

Could you please add two tests in macro_named_argument.rs:

  • 2 non-default arguments, no arguments provided in {% call %}
  • 1 non-default, 1 default argument, no arguments provided in {% call %}

@GuillaumeGomez
Copy link
Copy Markdown
Collaborator Author

Sure, done!

@Kijewski
Copy link
Copy Markdown
Member

Kijewski commented Feb 1, 2025

I think sometimes the wrong argument name was printed. Can you please verify if my change gets it right?

@Kijewski
Copy link
Copy Markdown
Member

Kijewski commented Feb 4, 2025

The PR needs rebasing, then the formatting error should be gone. I didn't do the rebase, so my change to your PR remains legible.

@GuillaumeGomez
Copy link
Copy Markdown
Collaborator Author

Forgot to check, let me get back to it.

@GuillaumeGomez
Copy link
Copy Markdown
Collaborator Author

Looks all good to me, thanks! I cannot approve my own PR though. 😅

@Kijewski Kijewski merged commit c130590 into askama-rs:master Feb 4, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compile error "macro expected at least N arguments..." is off by one.

2 participants