fix regexes in #quote-paragraph rule, and downstream#768
Open
andrewcarver wants to merge 1 commit intoasciidoctor:masterfrom
Open
fix regexes in #quote-paragraph rule, and downstream#768andrewcarver wants to merge 1 commit intoasciidoctor:masterfrom
andrewcarver wants to merge 1 commit intoasciidoctor:masterfrom
Conversation
As it stands, the regex in #quote-paragraph will not match any block-attribute-list that contains, itself, an inline macro -- such as a URL macro or a bibliographic-citation macro. Downstream from that rule, there are weaknesses also in the #block-attribute-inner rule. The fixes I've applied here are based on earlier discussion of this whole matter at asciidoctor/atom-language-asciidoc#197 -- where there are screen-shots and syntax-examples (too bad I was barking up the wrong tree ... Atom instead of VS Code!!).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a problem in the grammar: As it stands, the regex in rule #quote-paragraph will not match any block-attribute-list that contains, itself, an inline macro -- such as a URL macro or a bibliographic-citation macro. Downstream from that rule, there are weaknesses also in the #block-attribute-inner rule. The fixes I've applied here are based on earlier discussion of this whole matter in atom-language-asciidoc PR 197 -- where there are screen-shots and syntax-examples.
Resolves #767.