Add DX7 DAC Quantization to Mark I Engine#521
Open
grahamfranz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add DX7 DAC Quantization to Mark I Engine
Summary
Implements authentic Yamaha DX7 digital-to-analog converter (DAC) quantization in the Mark I synthesizer engine. The DX7 hardware uses a 12-bit DAC with a 3-bit analog scaler to handle the wide dynamic range of FM synthesis, creating characteristic quantization artifacts that are part of the original synth's sonic character.
Addresses feature request from issue #511 (thanks @dronus). This implementation focuses on the core 12-bit mantissa quantization; additional features like parameterized resistor network error simulation could be explored in future work.
Implementation
The
d7DacQuantize()function simulates the hardware behavior:Quantization behavior:
Hardware References
Testing & Verification
Verified the quantization function correctly:
Notes