Add converter from Turing using both Chains and Model#133
Add converter from Turing using both Chains and Model#133
Conversation
torfjelde
left a comment
There was a problem hiding this comment.
This looks like nice!
There are a couple of things that will break for certain models, but I provided some solutions that I'm pretty certain should work in essentially all cases:)
Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com>
|
Thanks, @torfjelde! I love that these changes both are more general and simplify the code quite a bit. Is it possible, given a |
Causes clash with ess
These are apparently overwritten by predict
You could just call Actually, did you figure this out on your own? Looking at |
Oh, you know, I didn't realize that all I had to do was sample from the prior, then compute the log likelihood, then I would have the observed data names. It's a little awkward, but it works now! Thanks! |
|
What is the status of this? This seems like it would make working with Turing models a lot smoother but perhaps there are some big downsides? |
This PR is a working prototype of the Turing part of the proposal in #132. With this PR, we can compute the final full
InferenceDatafrom the Turing example in the quickstart in a single line:It's marked draft because
falseto a group name if they don't want it to be generated.