Skip to content

fix build issue when disabling i2p support #8223#8233

Closed
gtumanyan wants to merge 2 commits intoarvidn:RC_2_0from
gtumanyan:patch-1
Closed

fix build issue when disabling i2p support #8223#8233
gtumanyan wants to merge 2 commits intoarvidn:RC_2_0from
gtumanyan:patch-1

Conversation

@gtumanyan
Copy link
Copy Markdown

No description provided.

@arvidn
Copy link
Copy Markdown
Owner

arvidn commented Mar 28, 2026

was there a good reason to provide a stub rather than disabling the call sites?

@gtumanyan
Copy link
Copy Markdown
Author

gtumanyan commented Mar 28, 2026

I do not understand.

disabling the call sites

  1. Would need #if at lines 186 AND 196 in announce_entry.cpp
  2. NO profit in speed
  3. The stub has NO memory consumption

@gtumanyan gtumanyan closed this Mar 28, 2026
@gtumanyan gtumanyan deleted the patch-1 branch March 28, 2026 17:40
@gtumanyan gtumanyan restored the patch-1 branch March 28, 2026 17:46
@gtumanyan gtumanyan reopened this Mar 28, 2026
@arvidn
Copy link
Copy Markdown
Owner

arvidn commented Mar 28, 2026

I think it's important to understand though

@gtumanyan gtumanyan closed this Mar 28, 2026
@gtumanyan gtumanyan deleted the patch-1 branch March 28, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants