fix: map Cmd/Meta to Ctrl on non-macOS platforms#171
Closed
kogasura wants to merge 1 commit intoarto-app:mainfrom
Closed
fix: map Cmd/Meta to Ctrl on non-macOS platforms#171kogasura wants to merge 1 commit intoarto-app:mainfrom
kogasura wants to merge 1 commit intoarto-app:mainfrom
Conversation
Author
Screenshots (Windows 11)Before (main branch)
After (this PR)
|
Preset keybindings use "Cmd+x" notation which maps to the Meta key on macOS. On Windows/Linux there is no Meta key, so map these to Ctrl instead so that "Cmd+n" behaves as "Ctrl+n". Tests use cfg!(target_os) to expect the correct modifier per platform.
kogasura
force-pushed
the
fix/windows-shortcut-mapping
branch
from
6d61da9 to
57a061b
Compare
Author
|
Closing in favor of addressing the root cause first (asset loading on Windows). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preset keybindings use
Cmd+xnotation which maps to theMETAkey on macOS. On Windows/Linux there is no Meta key equivalent, so keyboard shortcuts likeCmd+n(New Window) andCmd+o(Open Directory) do not work.This PR maps
Cmd/Meta/Commandmodifiers toCONTROLon non-macOS platforms, soCmd+nbehaves asCtrl+non Windows/Linux.Changes
desktop/src/shortcut.rs: Add#[cfg(target_os = "macos")]/#[cfg(not(target_os = "macos"))]conditional compilation for modifier mappingTest plan
cargo checkpasses on Windows (0 errors)