feat(infra): add Windows platform support and safe asset loading#170
Open
kassyi wants to merge 5 commits intoarto-app:mainfrom
Open
feat(infra): add Windows platform support and safe asset loading#170kassyi wants to merge 5 commits intoarto-app:mainfrom
kassyi wants to merge 5 commits intoarto-app:mainfrom
Conversation
7772b5b to
392e331
Compare
392e331 to
afa52b1
Compare
…_imports, justfile) to ensure a green base for all PRs
afa52b1 to
081f9df
Compare
Member
|
I don't understand why this PR includes If styles things are broken in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows-shell := "pwsh.exe"to workspacesjustfileconfigsget_main_script_path()andget_main_style_path()inassets.rsto safely resolve WebView assets on Windows#[cfg(unix)]directives toipc/socket.rsto fixdead_codeand unused import warnings failing the CIPreviously, Windows builds would fail during the
just checkphase becauseshis unavailable natively on Windows, and becauseasset://protocols behaved differently than local absolute paths (C:\). This PR establishes the baseline necessary for Windows compatibility and ensures the CI pipeline passes on Windows environments.2026-04-05.033210.mp4
Test plan
just checkexecutes cleanly via PowerShell (pwsh) on Windowsfailed to load asseterrors formain.jsandmain.cssRelated issues