Skip to content

feat(infra): add Windows platform support and safe asset loading#170

Open
kassyi wants to merge 5 commits intoarto-app:mainfrom
kassyi:feat/windows-support
Open

feat(infra): add Windows platform support and safe asset loading#170
kassyi wants to merge 5 commits intoarto-app:mainfrom
kassyi:feat/windows-support

Conversation

@kassyi
Copy link
Copy Markdown

@kassyi kassyi commented Apr 5, 2026

Summary

  • Add windows-shell := "pwsh.exe" to workspaces justfile configs
  • Implement get_main_script_path() and get_main_style_path() in assets.rs to safely resolve WebView assets on Windows
  • Add conditionally compiled #[cfg(unix)] directives to ipc/socket.rs to fix dead_code and unused import warnings failing the CI

Previously, Windows builds would fail during the just check phase because sh is unavailable natively on Windows, and because asset:// protocols behaved differently than local absolute paths (C:\). This PR establishes the baseline necessary for Windows compatibility and ensures the CI pipeline passes on Windows environments.

2026-04-05.033210.mp4

Test plan

  • Verify just check executes cleanly via PowerShell (pwsh) on Windows
  • Verify the app compiles and launches natively on Windows without failed to load asset errors for main.js and main.css
  • Verify CI pipeline completes the Windows target build matrix successfully

Related issues

@kassyi kassyi changed the title Feat/windows support feat(infra): add Windows platform support and safe asset loading Apr 5, 2026
@kassyi kassyi force-pushed the feat/windows-support branch from 7772b5b to 392e331 Compare April 5, 2026 18:06
@kassyi kassyi force-pushed the feat/windows-support branch from 392e331 to afa52b1 Compare April 5, 2026 18:09
@kassyi kassyi force-pushed the feat/windows-support branch from afa52b1 to 081f9df Compare April 5, 2026 18:10
@lambdalisue
Copy link
Copy Markdown
Member

I don't understand why this PR includes style: run formatter (oxfmt) in reader or similar commits and that prevent me to review the PR. Please focus a single purpose.

If styles things are broken in main branch, please first explain the reason and create an isolated PR for fixing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants