fix(cmake): normalize ARCH_ID for x86_64 JIT sources on Windows#21
Open
ArqTras wants to merge 2 commits into
Open
fix(cmake): normalize ARCH_ID for x86_64 JIT sources on Windows#21ArqTras wants to merge 2 commits into
ArqTras wants to merge 2 commits into
Conversation
added 2 commits
May 13, 2026 19:10
The 3.12...3.31 range form raises default policies and breaks the LANGUAGE=C build of jit_compiler_x86_static.S on MSYS2 GCC. A plain minimum of 3.12 keeps CMake 4 compatibility.
Parent CMake may pass ARCH_ID from CMAKE_SYSTEM_PROCESSOR (e.g. AMD64 on Windows). RandomARQ only matched lowercase amd64/x86_64, so jit_compiler_x86 sources were skipped. Always normalize ARCH_ID with string(TOLOWER) after resolving the default.
Member
Author
|
build on mingw passed no other changes required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the parent project sets \ARCH_ID\ from \CMAKE_SYSTEM_PROCESSOR\ (e.g. AMD64 on Windows/MSYS2), RandomARQ only matched lowercase \�md64\ / \x86_64, so \jit_compiler_x86.cpp\ and \jit_compiler_x86_static.S\ were never added and the static library missed JIT symbols.
After resolving \ARCH_ID\ (inherited or from the host), always apply \string(TOLOWER)\ before the architecture checks so x86-64 JIT sources are included.
Fork branch: https://github.com/ArqTras/RandomARQ/tree/chore/mingw-arch-id-lowercase
Made with Cursor