Conversation
|
|
||||||||||||||||
|
|
Atlas detected changes to the desired schemaMigration Plan for atlas-action • View on Atlas Cloud-- Create "t1" table
CREATE TABLE `t1` (
`c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
`c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
`c1` integer NOT NULL,
`c2` integer NOT NULL
);Atlas lint results
📝 Steps to edit this migration plan1. Run the following command to pull the generated plan to your local workstation: atlas schema plan pull --url "atlas://atlas-action/plans/pr-476-R1cGcSfo" > pr-476-R1cGcSfo.plan.hcl2. Open 3. Push the updated plan to the registry using the following command: atlas schema plan push --pending --file pr-476-R1cGcSfo.plan.hcl4. Re-trigger the gh run rerun 22340958765 |
|
|
There was a problem hiding this comment.
Pull request overview
Implements a new schema/inspect GitHub Action for inspecting a live database schema and exposing the inspected schema as an action output.
Changes:
- Added a new
schema/inspectaction (Node entrypoint +action.yml) and wired it into the Go action runner (atlasaction.Actions). - Extended manifests/docs/tests to include the new action (manifest entry, README docs, Go unit tests, testscript txtar).
- Added CI coverage for the new action and updated Azure DevOps task UI rules to expose it.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| schema/inspect/index.js | Adds the shim entrypoint for the new schema/inspect action. |
| schema/inspect/action.yml | Declares inputs/outputs and Node runtime for the new GitHub Action. |
| atlasaction/testdata/github/schema-inspect.txtar | Adds testscript coverage for atlas-action --action=schema/inspect. |
| atlasaction/manifest.yml | Registers the new schema/inspect action in the generated manifest. |
| atlasaction/action_test.go | Adds Go unit tests for Actions.SchemaInspect. |
| atlasaction/action.go | Wires schema/inspect into command dispatch and implements SchemaInspect. |
| VERSION.txt | Bumps version to v1.14.3. |
| README.md | Documents the new action and adds it to the actions table. |
| .github/workflows/ci-go.yaml | Adds a CI job that runs ./schema/inspect and validates outputs. |
| .github/azure-devops/action/task.json | Exposes schema inspect in the Azure DevOps task and adds the format input. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * `url` - The URL of the database to inspect. For example: `mysql://root:pass@localhost:3306/db`. | ||
| * `exclude` - List of glob patterns used to select which resources to filter in inspection | ||
| see: https://atlasgo.io/declarative/inspect#exclude-schemas | ||
| * `format` - Go template to use to format the output. For example, `sql`. |
There was a problem hiding this comment.
The format input description is inconsistent with the action metadata and test expectations: here it says the value is a Go template but the example uses sql (which is not a template). Please either change the example to a real template (e.g. {{ sql . }}) or explicitly document that sql is accepted as a shorthand that expands to that template.
| * `format` - Go template to use to format the output. For example, `sql`. | |
| * `format` - Go template to use to format the output. For example, `{{ sql . }}`. |
| outputs: | ||
| schema: | ||
| description: The inspected schema of the database. |
There was a problem hiding this comment.
Do you know if there is a limit on the size of the output of a job?
There was a problem hiding this comment.
I considered that as well, but this is log output; it should handle large content by default.
There was a problem hiding this comment.
https://github.com/orgs/community/discussions/127903
A discussion indicates that the limit is 4 MB.
No description provided.