Translate Chinese source strings to English#10
Merged
Conversation
Replace Chinese text in logs, error messages, and probe output with English across MultitouchKit, ApplicationMonitorKit, Lunchpad app sources, and the diagnostic probes. AGENTS.md requires code comments, documentation, and release notes in English; this extends the same convention to runtime strings. Left unchanged: - zh-Hans.lproj/Localizable.strings (Chinese localization resource) - Tests asserting localized values (e.g. "设置", "计算器") - OpenSpec docs referencing expected localized values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translates Chinese text in logs, error messages, and probe output to English across
MultitouchKit,ApplicationMonitorKit, the Lunchpad app sources, and the diagnostic probes.AGENTS.mdrequires code comments, documentation, and release notes in English; this extends the same convention to runtime strings.What changed
MultitouchMonitorErrordescriptions and IOKit call labels (start/wait/read touch data stream).ApplicationDirectoryMonitorErrordescriptions (no roots, create/start FSEvents stream).LunchpadLayoutStoreErrordescriptions (folder name, not found, protected system folder, database not open, Application Support missing), catalog synchronizer logs,AppDelegatestartup/sync logs,IconGridViewlaunch error.MultitouchProbe,AppChangeProbe,GestureProbe): console instructions and status output.Intentionally left in Chinese
Sources/Lunchpad/Resources/zh-Hans.lproj/Localizable.strings— the Simplified Chinese localization resource itself.Tests/LunchpadTests/*— fixtures that assert actual localized values ("设置","计算器","其他","创建时间","修改时间") and verify the scanner/search handle non-ASCII localized bundle names. Translating them would defeat the tests.openspec/— spec documents that reference expected localized values as requirements.Verification
swift build— clean.swift test— 120 tests pass.git diff --check— no whitespace issues.The 9 changed files contain only string-literal text changes; no control flow, API, or test semantics were altered.