Conversation
f57a23f to
063093c
Compare
There was a problem hiding this comment.
Pull request overview
This pull request modifies PNG decoding logic to gracefully handle unexpected EOF errors instead of failing. The changes allow processing truncated or corrupted PNG files by treating unexpected EOF conditions as a natural end of data stream.
Changes:
- Modified
read_next_rgba_rowto return a boolean indicating success and handle EOF gracefully - Added
is_unexpected_eof_decode_errorhelper function to detect EOF errors - Converted row processing loops from
forloops towhileloops that can handle early termination
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib.rs | Core PNG processing logic updated to tolerate EOF and handle truncated images |
| test/index.spec.ts | Added test cases for truncated PNG files |
| test/fixtures/weird-diff.png | Test fixture: truncated PNG file |
| test/fixtures/weird-diff-2.png | Test fixture: truncated PNG file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.