Conversation
Member
gregberge
commented
Jan 13, 2026
- feat: accept a filepath or a buffer
- feat: optimize memory usage
There was a problem hiding this comment.
Pull request overview
This PR optimizes memory usage in the PNG fingerprinting library by eliminating intermediate buffer allocations and adds support for accepting file paths as input in addition to buffers.
Changes:
- Refactored
fingerprint_diffto accept either a file path (string) or buffer as input - Optimized PNG decoding to avoid unnecessary copying for RGBA8 format images
- Merged the hash computation directly into the grid density calculation to eliminate intermediate buffers (
pack_2bitandfnv1a64functions removed)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib.rs | Added filepath/buffer input support, optimized RGBA8 decoding path, and merged packing/hashing into hash_grid_density to eliminate intermediate allocations |
| index.d.ts | Updated TypeScript signature to accept string | Buffer instead of just Buffer |
| test/index.spec.ts | Added test case to verify filepath input produces same fingerprint as buffer input |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.