fix(controller): ensure progress when canary > desired replicas

[andrewjamesbrown]

We've experienced a stall in our canary process when an HPA is configured with 1 replica, but we set minPodsPerReplicaSet: 2 in the rollout. Turns out that we check whether the canary replicaset is not equal to the desired, but don't handle the case where it is greater than the desired; which should also be treated as success.

We have these logs that repeat ad infinutum:

Started syncing rollout
Found 1 TrafficRouting Reconcilers
Reconciling TrafficRouting with type 'Istio'
DestinationRule my-service subset updated (canary: 6d64947786, stable: 6f6f4bdc4c)
No Steps remain in the canary steps
No status changes. Skipping patch
Queueing up Rollout for a progress check now
Reconciliation completed

Our rollout:

% k get rollout
NAME                     DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
my-service               1         3         2            3           465d

% k get rs
NAME                                DESIRED   CURRENT   READY   AGE
my-service-6d64947786               2         2         2       5h36m
my-service-6f6f4bdc4c               1         1         0       3d3h

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Published E2E Test Results

  4 files    4 suites   3h 30m 21s ⏱️
120 tests 110 ✅  7 💤 3 ❌
484 runs  453 ✅ 28 💤 3 ❌

For more details on these failures, see this check.

Results for commit bb3a682.

[github-actions]

Published Unit Test Results

2 395 tests   2 395 ✅  3m 4s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit bb3a682.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.41%. Comparing base (348260a) to head (bb3a682).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4619      +/-   ##
==========================================
+ Coverage   84.40%   84.41%   +0.01%     
==========================================
  Files         164      164              
  Lines       18855    18855              
==========================================
+ Hits        15914    15916       +2     
+ Misses       2077     2076       -1     
+ Partials      864      863       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.