fix(trafficrouting): ensure DestinationRule is updated before SetWeight on rollback#4612
Open
andrewjamesbrown wants to merge 1 commit intoargoproj:masterfrom
Open
Conversation
Contributor
Published E2E Test Results 4 files 4 suites 3h 28m 8s ⏱️ Results for commit de6a333. ♻️ This comment has been updated with latest results. |
Contributor
Published Unit Test Results2 391 tests 2 391 ✅ 3m 5s ⏱️ Results for commit de6a333. ♻️ This comment has been updated with latest results. |
andrewjamesbrown
force-pushed
the
fix/istio-rollback-vs-dr-order
branch
2 times, most recently
from
0434159 to
b365e5c
Compare
…lback
- Return error from UpdateHash when delaying DR switch so SetWeight is not
called, preventing VS weight update before DR subset switch (fixes rollback
traffic hitting wrong subsets).
- When shifting traffic to stable only (abort or dynamic rollback), only
require stable RS availability so abort still completes when canary is
failed (no regression of argoproj#4128).
Signed-off-by: Andrew Brown <andrew.brown@wealthsimple.com>
andrewjamesbrown
force-pushed
the
fix/istio-rollback-vs-dr-order
branch
from
b365e5c to
de6a333
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4612 +/- ##
==========================================
- Coverage 84.40% 84.37% -0.03%
==========================================
Files 164 164
Lines 18855 18860 +5
==========================================
Hits 15914 15914
- Misses 2077 2080 +3
- Partials 864 866 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Possibly related to #4390 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have experienced several incidents where we have a canary in-progress, and we want to do a rollback to a previous stable release that is within the rollback window (i.e. fast rollback). What we experience is that Argo Rollouts will delay the DestinationRule switch (since the target is not ready), but still set the weight to the final weight in the
stepslist, resulting in a canary getting 70% of traffic in our case, while it is only scaled to handle 5%. This creates an overload condition on the canary, spiking latency and impact to any clients calling the service.The fix:
Related PRs:
#4299
#3602
Checklist:
"fix(controller): Updates such and such. Fixes #1234".