Skip to content

fix: update broken yarn.lock file#4603

Merged
zachaller merged 1 commit intoargoproj:masterfrom
Rizwana777:fix-yarn
Jan 30, 2026
Merged

fix: update broken yarn.lock file#4603
zachaller merged 1 commit intoargoproj:masterfrom
Rizwana777:fix-yarn

Conversation

@Rizwana777
Copy link
Contributor

@Rizwana777 Rizwana777 commented Jan 27, 2026

It was observed that due to broken yarn.lock file, the Argo Rollouts source-code fails to build on disconnected systems which uses npm cache to provide node packages. This PR fixes the yarn.lock file by simply running yarn install in the ui directory.

It might be broken because the lockfile have been manually edited without full regeneration, resulting in missing entries for:

  • loader-utils@^1.1.0, loader-utils@^1.2.3, loader-utils@^1.4.0
  • loader-utils@2.0.0 (exact version required by react-dev-utils)
  • loader-runner@^2.4.0

These packages are dependencies required by:

  • babel-loader
  • css-loader
  • file-loader
  • react-dev-utils
  • webpack-related loaders

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Published E2E Test Results

  4 files    4 suites   3h 25m 58s ⏱️
117 tests 108 ✅  7 💤 2 ❌
476 runs  440 ✅ 28 💤 8 ❌

For more details on these failures, see this check.

Results for commit 89240b3.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.34%. Comparing base (c6dfed2) to head (89240b3).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4603      +/-   ##
==========================================
- Coverage   84.40%   84.34%   -0.06%     
==========================================
  Files         164      164              
  Lines       18849    18849              
==========================================
- Hits        15909    15899      -10     
- Misses       2077     2082       +5     
- Partials      863      868       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

Published Unit Test Results

2 373 tests   2 373 ✅  3m 4s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit 89240b3.

@zachaller zachaller merged commit ef8099f into argoproj:master Jan 30, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants