Eliminate critical code duplication in Windows & Unix modules#197
Open
Eliminate critical code duplication in Windows & Unix modules#197
Conversation
- Extract common GetComputerNameExW pattern into get_computer_name() helper - Consolidate duplicate ERR_MORE_DATA error check - Consolidate duplicate buffer allocation pattern in devicename/hostname - No functional changes, improves maintainability
naoNao89
force-pushed
the
refactor/remove-critical-duplicates
branch
from
07c3245 to
1dfcb0b
Compare
Member
|
@naoNao89 this looks good, thank you for the PR! Can you open separate PRs for the two commits? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i found and fixed some exact duplicates. Extracted shared logic into helper functions
get_computer_name()for Windows API calls andos_from_cstring_impl()for Unix C strings.