fix: A2A JSON-RPC v2: 1.0 Protocol-compliant#4380
Open
ilyakorovin wants to merge 2 commits intoarchestra-ai:mainfrom
Open
fix: A2A JSON-RPC v2: 1.0 Protocol-compliant#4380ilyakorovin wants to merge 2 commits intoarchestra-ai:mainfrom
ilyakorovin wants to merge 2 commits intoarchestra-ai:mainfrom
Conversation
48efc9f to
63fa2b9
Compare
63fa2b9 to
18d7e2c
Compare
18d7e2c to
4879557
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4370
Fixed agent card
Now it's 1.0-compliant. Official Python SDK recognizes it automatically without explicit protocol version and agent card path specifying.
Fixed methods names
message/send->SendMessagetask/get->GetTaskPrevious impl was for
0.3Fixed client messageId
Previously it was effectively ignored.
Message parts are optional
partsfield is required by A2A Protocol, but Python SDK converts empty parts array to undefined.On our side
message.partsare always defined.Fixed potential losing history in stateful mode
I didn't catch the bug in live, but potentially in A2A JSON-RPC it was possible to get an error in approval decision request, because of stale data via pg update+select anti-pattern.
Some tests and small bug fixes
There were bugs like missing
contextIdandtaskIdin theSendMessageresponse.There is a sample tool that uses Python SDK for working with Archestra A2A JSON-RPC v2:
https://github.com/ilyakorovin/archestra-a2a-client-sample/tree/main/python
It's LLM-generated and ugly. But it supports interactive mode:
Just type some text and press enter, it will execute
SendMessage. In case of approval request it should ask "y/n". Further messages during the session should be within the samecontextId.It also supports
message/approvesub-commands for more manual working withSendMessageand approval decisions.