fix: fixed name field is mandatory issue#4371
fix: fixed name field is mandatory issue#4371Rutetid wants to merge 5 commits intoarchestra-ai:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the knowledge settings “Add LLM Provider Key” dialog so the Name field truly behaves as optional, matching the UI and the linked issue. It updates the create flow in the settings page to allow blank names and substitute the selected provider’s display name.
Changes:
- Removes the Name field from the client-side submit eligibility check.
- Trims the submitted name before sending it to the create mutation.
- Falls back to
PROVIDER_CONFIG[provider].namewhen the user leaves Name blank.
|
added the test pls review @copilot |
Co-authored-by: Copilot <copilot@github.com>
|
my bad, fixed the lint error |
|
If backend requires name, maybe just let's make it required in UI? |
@Konstantinov-Innokentii , in this implementation we are falling back to the model name if the user does not provide any name, so we can do that or as you said we can make it mandatory in the UI itself. Which implementation should we go forward with? |
|
If it's required on backend, let's just make it required on frontend too? |
Summary
Fixes #4369
Fixes a UX mismatch where the Name field is labeled optional but required to submit.
Changes
Testing
All frontend test and pnpm check:ci passes
Screen Recording
2026-05-05.16-55-49.mp4