Fix bug in modal dismissal of SKStoreProductViewController#119
Open
jeffarena wants to merge 1 commit intoarashpayan:masterfrom
Open
Fix bug in modal dismissal of SKStoreProductViewController#119jeffarena wants to merge 1 commit intoarashpayan:masterfrom
jeffarena wants to merge 1 commit intoarashpayan:masterfrom
Conversation
Per the iOS View Controller Programming Guide, a modal view should be dismissed by the controller that presented it originally. Currently, the modally presented SKStoreProductViewController is dismissing itself, which is incorrect. We fix this issue by storing a weak reference to the presenting view controller and using it to dismiss the modal view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the iOS View Controller Programming Guide, a modal view should be
dismissed by the controller that presented it originally. Currently,
the modally presented SKStoreProductViewController is dismissing itself,
which is incorrect. We fix this issue by storing a weak reference to
the presenting view controller and using it to dismiss the modal view.