Fix off by one bug, and added reset method, and refactored debug mode#111
Open
Zakay wants to merge 1 commit intoarashpayan:masterfrom
Zakay:master
Open
Fix off by one bug, and added reset method, and refactored debug mode#111Zakay wants to merge 1 commit intoarashpayan:masterfrom Zakay:master
Zakay wants to merge 1 commit intoarashpayan:masterfrom
Zakay:master
Conversation
Zakay
commented
Apr 10, 2013
Zakay
commented
- Fixed off by one bug with events and uses
- setDebug only shows debug, make its much clearer on what it really is
- setForceRatingConditionsMet which triggers the rating alert all the time, this instead of the old setDebug if you only want to trigger the alert
- Added new method reset : Resets database, useful for testing
* setDebug only shows debug * setForceRatingConditionsMet which triggers the rating alert all the time * Added new method reset : Resets database, useful for testing
|
👍 |
|
👍 At least merge the off-by-one fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.