Home page first design mockup - #1048
Conversation
|
Deploy Preview Available Via |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
This and a few other template files added again that break the example rendering!
| @@ -0,0 +1,191 @@ | |||
| {{ define "main" -}} | |||
| {{ $stable := "arangodb/stable/" -}} | |||
There was a problem hiding this comment.
Not great. Can we move the content to a Markdown file and use the usual hardcoded 3.12 links that then get replaced dynamically with JavaScript to whatever ArangoDB version is/was last selected by the user?
Maybe this substitution can also work on theme files like this, I haven't ever tried. But <a> elements likely need the link class for that to get picked up.
| {{ define "main" -}} | ||
| {{ $stable := "arangodb/stable/" -}} | ||
| <article class="home home-landing"> | ||
| <style> |
There was a problem hiding this comment.
A lot of inline styles, but I suppose this is okay because it's limited to the one page - adding it to the theme.css or a separate .css file wouldn't make much sense.
| <h1>{{ .Title | markdownify }}</h1> | ||
| {{ with .Description }}<p class="home-lead">{{ . | markdownify }}</p>{{ end }} | ||
| <nav class="home-cta" aria-label="Primary shortcuts"> | ||
| <a class="primary" href="{{ (print $stable "get-started/") | relURL }}"><i class="fas fa-rocket"></i>Get started</a> | ||
| <a href="#choose-path"><i class="fas fa-directions"></i>Choose your path</a> | ||
| <a href="#popular-tasks"><i class="fas fa-tasks"></i>Find a task</a> | ||
| <a href="{{ (print $stable "release-notes/") | relURL }}"><i class="fas fa-code-branch"></i>Release notes</a> | ||
| </nav> |
There was a problem hiding this comment.
I guess it's difficult to have this content in Markdown due to the use of elements and classes that can't easily/nicely be set in Markdown... Not great to have all this as HTML for later maintenance, although with Claude it should be fine.
| <h2 id="quick-starts">Quick start guides</h2> | ||
| <p class="home-note">New to Arango? Pick a starting point and get to a working result fast. The full product manuals live in the sidebar on the left.</p> | ||
| <section class="home-grid cols-2"> | ||
| <a class="qcard" href="{{ (print $stable "get-started/") | relURL }}"> |
There was a problem hiding this comment.
None of the internal links here will be validated because that is only one in the render hook for Markdown links, which isn't ideal. Links in SVGs are also not checked. Maybe we can add an additional checker for these cases?
3 participants
Description
Upstream PRs