Conversation
|
@cycle-five can you open an issue that this PR relates too? In that issue you could explain the rationale behind this feature. |
StaticRocket
left a comment
StaticRocket
left a comment
There was a problem hiding this comment.
The feature works and the fragmentation of URL parsing and playback seems rational. Consider this approval superficial though, as I'm no rust expert and can't attest to the implementation.
afonsojramos
left a comment
afonsojramos
left a comment
There was a problem hiding this comment.
Only a half review, need to pay some proper attention to play.rs and file.rs still.
| } | ||
|
|
||
| #[derive(Clone)] | ||
| #[derive(Clone, Debug)] |
There was a problem hiding this comment.
I assume we will change this once it is "ready"?
There was a problem hiding this comment.
I actually usually leave the Debug derive in because it provides a certain level of detail in logs, but I'll remove it if it's not idiomatic to have in production code.
Co-authored-by: Afonso Jorge Ramos <afonsojorgeramos@gmail.com>
|
@cycle-five added you as a co-author in a separate PR (#255), as multiple things needed addressing for this feature. |
4 participants
Uh oh!
There was an error while loading. Please reload this page.