Skip to content

fix(KSV104): add ephemeralContainers support to seccomp profile check #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adityaupasani2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(KSV104): add ephemeralContainers support to seccomp profile check #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion checks/kubernetes/seccomp_profile_unconfined.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# - no-seccomp-unconfined
# - kubernetes-no-seccomp-unconfined
# severity: MEDIUM
# recommended_action: "Specify seccomp either by annotation or by seccomp profile type having allowed values as per pod security standards"
# recommended_action: "Specify seccomp either by annotation or by seccomp profile type having allowed values as per pod security standards for containers, initContainers, and ephemeralContainers"
# input:
# selector:
# - type: kubernetes
Expand Down
53 changes: 53 additions & 0 deletions checks/kubernetes/seccomp_profile_unconfined_test.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,3 +251,56 @@ test_deployment_annotations_seccomp_profile_unconfined_allowed if {
}
count(r) == 0
}
test_init_container_seccomp_profile_unconfined_denied if {
r := deny with input as {
"apiVersion": "v1",
"kind": "Pod",
"metadata": {"name": "hello-sysctls"},
"spec": {
"containers": [{"name": "hello", "image": "busybox", "securityContext": {"seccompProfile": {"type": "RuntimeDefault"}}}],
"initContainers": [{"name": "init-hello", "image": "busybox", "securityContext": {"seccompProfile": {"type": "Unconfined"}}}],
},
}
count(r) == 1
contains(r[_].msg, "init-hello")
}

test_init_container_seccomp_profile_unconfined_allowed if {
r := deny with input as {
"apiVersion": "v1",
"kind": "Pod",
"metadata": {"name": "hello-sysctls"},
"spec": {
"containers": [{"name": "hello", "image": "busybox", "securityContext": {"seccompProfile": {"type": "RuntimeDefault"}}}],
"initContainers": [{"name": "init-hello", "image": "busybox", "securityContext": {"seccompProfile": {"type": "RuntimeDefault"}}}],
},
}
count(r) == 0
}

test_ephemeral_container_seccomp_profile_unconfined_denied if {
r := deny with input as {
"apiVersion": "v1",
"kind": "Pod",
"metadata": {"name": "hello-sysctls"},
"spec": {
"containers": [{"name": "hello", "image": "busybox", "securityContext": {"seccompProfile": {"type": "RuntimeDefault"}}}],
"ephemeralContainers": [{"name": "ephemeral-hello", "image": "busybox", "securityContext": {"seccompProfile": {"type": "Unconfined"}}}],
},
}
count(r) == 1
contains(r[_].msg, "ephemeral-hello")
}

test_ephemeral_container_seccomp_profile_unconfined_allowed if {
r := deny with input as {
"apiVersion": "v1",
"kind": "Pod",
"metadata": {"name": "hello-sysctls"},
"spec": {
"containers": [{"name": "hello", "image": "busybox", "securityContext": {"seccompProfile": {"type": "RuntimeDefault"}}}],
"ephemeralContainers": [{"name": "ephemeral-hello", "image": "busybox", "securityContext": {"seccompProfile": {"type": "RuntimeDefault"}}}],
},
}
count(r) == 0
}
26 changes: 13 additions & 13 deletions lib/kubernetes/kubernetes.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,19 +97,19 @@ split_image(image) := [image_name, tag] if {
}

pod_containers(pod) := all_containers if {
keys = {"containers", "initContainers"}
all_containers = [c |
keys[k]
some container in pod.spec[k]
c := json.patch(
container,
[{
"op": "add",
"path": "securityContext",
"value": k8s_sec_context.resolve_container_sec_context(pod, container),
}],
)
]
keys = {"containers", "initContainers", "ephemeralContainers"}
all_containers = [c |
keys[k]
some container in pod.spec[k]
c := json.patch(
container,
[{
"op": "add",
"path": "securityContext",
"value": k8s_sec_context.resolve_container_sec_context(pod, container),
}],
)
]
}

containers contains container if {
Expand Down