Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Based on #13 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the file structure by moving header files into categorized subdirectories under the kf namespace (containers, encoding, filesystem, guard, string, sync, thread, transport) and adds a test infrastructure. The reorganization improves code organization and maintainability by grouping related functionality together.
Key changes:
- Restructured include paths to use categorized directories (e.g.,
kf/guard/,kf/string/,kf/containers/) - Added CMake build configuration for both the main project and test suite
- Implemented test infrastructure with precompiled headers and hex encoding tests
Reviewed Changes
Copilot reviewed 21 out of 58 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Main project CMake configuration with compiler settings and WDK integration |
| include/CMakeLists.txt | Library configuration with interface target and header organization |
| test/CMakeLists.txt | Test project setup with kmtest framework integration |
| test/pch.h | Precompiled header for tests with STL compatibility shims |
| test/pch.cpp | Precompiled header implementation |
| test/HexTest.cpp | Unit tests for hex encoding/decoding functionality |
| include/kf/encoding/Hex.h | Enhanced hex encoder with Unicode decode support and improved constants |
| Multiple header files | Updated include paths to use new categorized structure |
Comments suppressed due to low confidence (1)
test/pch.h:15
- The _CrtDbgReport function returns 0 unconditionally, which may not provide proper debugging support for tests. Consider implementing basic debug output or logging.
// TODO: implement proper debug report handling
include/kf/encoding/Hex.h
Outdated
| return false; | ||
| } | ||
|
|
||
| output[i/kEncodedSizeMultiplier] = static_cast<std::byte>(res); |
There was a problem hiding this comment.
The index calculation is incorrect. It should be i / kEncodedSizeMultiplier but since i is incremented by kEncodedSizeMultiplier, it should be (i / kEncodedSizeMultiplier) or better yet, use a separate output index variable to avoid confusion.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.