Skip to content

Fix CLI Windows browser launch and bump console SDK#1609

Merged
ChiragAgg5k merged 4 commits into
mainfrom
fix/cli-open-browser-windows-url
Jun 24, 2026
Merged

Fix CLI Windows browser launch and bump console SDK#1609
ChiragAgg5k merged 4 commits into
mainfrom
fix/cli-open-browser-windows-url

Conversation

@ChiragAgg5k

@ChiragAgg5k ChiragAgg5k commented Jun 23, 2026

Copy link
Copy Markdown
Member

Summary

  • Fix Windows CLI browser launch by avoiding cmd /c start and passing the URL directly to rundll32 url.dll,FileProtocolHandler.
  • Bump @appwrite.io/console to ^15.1.1 and refresh CLI npm/bun lock templates.
  • Add a regression test that verifies Windows browser launch preserves URLs containing spaces and cmd metacharacters.

Testing

  • php example.php cli
  • ./scripts/update-lockfiles.sh cli
  • composer refactor:check
  • composer lint-twig
  • vendor/bin/phpunit tests/e2e/CLIBun13Test.php

Related Issue

  • #XXXX

@ChiragAgg5k ChiragAgg5k changed the title Fix CLI Windows browser URL launch Fix CLI Windows browser launch and bump console SDK Jun 23, 2026
@greptile-apps

greptile-apps Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the CLI browser launch path on Windows and refreshes the console SDK dependency. The main changes are:

  • Windows browser opening now uses rundll32 url.dll,FileProtocolHandler with the URL as a direct argument.
  • CLI package and lock templates now depend on @appwrite.io/console ^15.1.1.
  • The CLI auth tests now cover Windows URLs with spaces and command metacharacters.

Confidence Score: 5/5

The changes are narrowly scoped and covered by a regression test for the Windows URL handling behavior.

The updated browser-launch command avoids shell interpretation and the dependency bump is reflected consistently across package templates and lockfiles.

T-Rex T-Rex Logs

What T-Rex did

  • Compared the Windows browser launch logs; the base run used CMD to start the URL, while the head run used rundll32 with FileProtocolHandler to open the URL and set URL_ARG_EXACT to true.
  • Compared the package manifests and lockfiles; the base state shows ^15.1.0 with npm and bun at 15.1.0, and the head state shows ^15.1.1 with npm and bun at 15.1.1, with consistency checks passing.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (3): Last reviewed commit: "Fix Windows open browser test expectatio..." | Re-trigger Greptile

Comment thread templates/cli/lib/utils.ts Outdated
Comment thread templates/cli/lib/utils.ts Outdated
@ChiragAgg5k ChiragAgg5k merged commit c4882c7 into main Jun 24, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant