The Open Graph standard allows for additional metadata to be supplied…#21
Open
jamesapyrich wants to merge 2 commits intoappunite:masterfrom
Open
The Open Graph standard allows for additional metadata to be supplied…#21jamesapyrich wants to merge 2 commits intoappunite:masterfrom
jamesapyrich wants to merge 2 commits intoappunite:masterfrom
Conversation
… to an image. However, every image description must begin with the strict string "og:image". Hence, only selecting that attribute is sufficient for our uses here.
Author
|
I discovered this issue due to link_preview pulling in height & width attributes that were clearly not images. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to an image. However, every image description must begin with the strict string "og:image". Hence, only selecting that attribute is sufficient for our uses here.