Respect activejob log arguments per library rebased - #1506
Closed
tombruijn wants to merge 4 commits into
Closed
Conversation
When an ActiveJob class has log_arguments set to false, AppSignal now skips collecting job arguments for that transaction. This prevents sensitive data from appearing in AppSignal when Rails is explicitly configured not to log them. This applies when log_arguments is set: - Directly on a job class (e.g. self.log_arguments = false) - On a parent class (e.g. ApplicationJob), inherited by subclasses The implementation adds a log_arguments? helper that resolves the job class from the serialized job data and checks the class-level log_arguments? setting. It defaults to true (collect arguments) when the class cannot be resolved or does not support the method, ensuring backward compatibility. Closes #1487
Guard the log_arguments tests with a Rails 6.1+ version check since the log_arguments class attribute was introduced in Rails 6.1. Add a test that verifies fallback behavior when log_arguments? is not supported by the job class. Fixes #1487
Document the Lintje commit message rules so that AI assistants follow the project's commit conventions. [skip changeset] Part of #1487
When a customer Configures ActiveJob `log_arguments` to be false, it would not adhere to this in the other integrations like Sidekiq, DelayedJob, etc. Implemented this logic in Sidekiq so that it doesn't set the parameters if they're unset on ActiveJob.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test PR, ignore.