chore: support timeoutSeconds in action execution#9955
Conversation
|
Auto Cherry-pick Instructions |
|
/pick release-1.0 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9955 +/- ##
==========================================
+ Coverage 51.06% 51.69% +0.62%
==========================================
Files 541 541
Lines 58340 58831 +491
==========================================
+ Hits 29793 30410 +617
+ Misses 25611 25489 -122
+ Partials 2936 2932 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pkg/kbagent/service/action_utils.go
Outdated
| } else if *timeout > 0 { | ||
| ctx, cancel = context.WithTimeout(ctx, min(time.Duration(*timeout)*time.Second, maxActionCallTimeout)) | ||
| } | ||
| ctx, cancel = actionCallTimeout(ctx, action.TimeoutSeconds, timeout) |
There was a problem hiding this comment.
Why there are two timeout settings? Should the timeout defined in cmpd types be enough?
There was a problem hiding this comment.
Disable the request timeout for now.
61542b8 to
a608857
Compare
pkg/kbagent/service/action_utils.go
Outdated
| defaultMaxIdleConnectionsPerHost = 20 | ||
|
|
||
| defaultActionCallTimeout = 30 * time.Second | ||
| defaultActionCallTimeout = 15 * time.Second |
There was a problem hiding this comment.
Perhaps 30 seconds would be more appropriate for adopted add-ons.
|
/approve |
a608857 to
3580e66
Compare
|
/approve |
|
/cherry-pick release-1.0 |
|
🤖 says: Error cherry-picking. |
|
🤖 says: |
close #9953