Skip to content

fix: use the cluster namespace if the secret-ref namespace of the TLS issuer is not set#9791

Merged
leon-inf merged 1 commit intomainfrom
bugfix/secretref-namespace
Oct 10, 2025
Merged

fix: use the cluster namespace if the secret-ref namespace of the TLS issuer is not set#9791
leon-inf merged 1 commit intomainfrom
bugfix/secretref-namespace

Conversation

@leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Oct 9, 2025

close #9784

@leon-inf leon-inf added this to the Release 1.1.0 milestone Oct 9, 2025
@leon-inf leon-inf requested a review from a team as a code owner October 9, 2025 03:30
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 9, 2025
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@leon-inf
Copy link
Contributor Author

leon-inf commented Oct 9, 2025

/pick release-1.0

@apecloud-bot apecloud-bot added the pick-1.0 Auto cherry-pick to release-1.0 when PR merged label Oct 9, 2025
@leon-inf leon-inf force-pushed the bugfix/secretref-namespace branch from 0cb57e2 to 7085c22 Compare October 9, 2025 03:55
@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.77%. Comparing base (3c80e71) to head (7085c22).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ollers/apps/component/transformer_component_tls.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9791      +/-   ##
==========================================
+ Coverage   59.60%   59.77%   +0.16%     
==========================================
  Files         551      551              
  Lines       59762    59766       +4     
==========================================
+ Hits        35624    35726     +102     
+ Misses      20884    20796      -88     
+ Partials     3254     3244      -10     
Flag Coverage Δ
unittests 59.77% <0.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 9, 2025
@leon-inf leon-inf merged commit 567c7f1 into main Oct 10, 2025
41 checks passed
@leon-inf leon-inf deleted the bugfix/secretref-namespace branch October 10, 2025 02:03
@apecloud-bot
Copy link
Collaborator

/cherry-pick release-1.0

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/18394259044

apecloud-bot pushed a commit that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test pick-1.0 Auto cherry-pick to release-1.0 when PR merged size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] issuer.secretRef.namespace is not optional

5 participants