Skip to content

chore: restart component and check component status #9753

Merged
shanshanying merged 2 commits intomainfrom
support/update-restart-policy-use-cmp-restart
Sep 19, 2025
Merged

chore: restart component and check component status #9753
shanshanying merged 2 commits intomainfrom
support/update-restart-policy-use-cmp-restart

Conversation

@shanshanying
Copy link
Contributor

@shanshanying shanshanying commented Sep 18, 2025

  1. restart component instead of ITS (by add the annotation)
  2. check both progress and component status.
    The paramter change is succ only when PROGRESS equals |pods| and component status is running,

@shanshanying shanshanying requested a review from a team as a code owner September 18, 2025 07:48
@shanshanying shanshanying marked this pull request as draft September 18, 2025 07:48
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Sep 18, 2025
@github-actions github-actions bot added this to the Release 1.1.0 milestone Sep 18, 2025
@shanshanying shanshanying reopened this Sep 18, 2025
@shanshanying shanshanying force-pushed the support/update-restart-policy-use-cmp-restart branch from 2d89bf1 to 1248f01 Compare September 18, 2025 10:18
@shanshanying shanshanying marked this pull request as ready for review September 19, 2025 02:07
@shanshanying shanshanying added the pick-1.0 Auto cherry-pick to release-1.0 when PR merged label Sep 19, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 19, 2025
@shanshanying shanshanying changed the title chore: restart component and check component status in parameter rest… chore: restart component and check component status Sep 19, 2025
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Sep 19, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 19, 2025
@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.71%. Comparing base (ac5922d) to head (38af036).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
controllers/parameters/restart_policy.go 53.84% 3 Missing and 3 partials ⚠️
controllers/parameters/policy_util.go 86.95% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9753      +/-   ##
==========================================
+ Coverage   59.67%   59.71%   +0.03%     
==========================================
  Files         551      551              
  Lines       59890    59876      -14     
==========================================
+ Hits        35738    35752      +14     
+ Misses      20904    20867      -37     
- Partials     3248     3257       +9     
Flag Coverage Δ
unittests 59.71% <75.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shanshanying shanshanying merged commit 6e37910 into main Sep 19, 2025
40 checks passed
@shanshanying shanshanying deleted the support/update-restart-policy-use-cmp-restart branch September 19, 2025 09:01
@apecloud-bot
Copy link
Collaborator

/cherry-pick release-1.0

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/17853703503

apecloud-bot pushed a commit that referenced this pull request Sep 19, 2025
Co-authored-by: wusai80 <wusai80@gmail.com>
(cherry picked from commit 6e37910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test pick-1.0 Auto cherry-pick to release-1.0 when PR merged size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants