chore: refine the settings of the manager#9587
Merged
Conversation
Collaborator
|
Auto Cherry-pick Instructions |
Contributor
Author
|
/pick release-1.0 |
leon-inf
force-pushed
the
support/refine-manager-configs
branch
from
c316595 to
314221f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9587 +/- ##
==========================================
+ Coverage 59.83% 59.95% +0.11%
==========================================
Files 518 518
Lines 56345 56359 +14
==========================================
+ Hits 33712 33788 +76
+ Misses 19619 19561 -58
+ Partials 3014 3010 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zjx20
reviewed
Aug 1, 2025
cmd/manager/main.go
Outdated
| flag.String(leaderElectIDFlagKey.String(), "001c317f", | ||
| "The leader election ID prefix for controller manager. "+ | ||
| "This ID must be unique to controller manager.") | ||
| flag.Duration(leaderElectLeaseDurationFlagKey.String(), time.Duration(15), |
Contributor
There was a problem hiding this comment.
Suggest using flag.Int() instead. For flag.Duration(), it allows users to set a duration like "1m20s", and "15" actually means 15 nanoseconds. Using flag.Int() is more idiomatic, if its default unit is "seconds".
leon-inf
force-pushed
the
support/refine-manager-configs
branch
from
314221f to
3fda809
Compare
github-actions
bot
added
size/L
leon-inf
force-pushed
the
support/refine-manager-configs
branch
from
3fda809 to
32d7d80
Compare
leon-inf
force-pushed
the
support/refine-manager-configs
branch
from
32d7d80 to
780a27c
Compare
zjx20
approved these changes
Aug 4, 2025
Contributor
Author
|
/approve |
apecloud-bot
approved these changes
Aug 4, 2025
Collaborator
|
/cherry-pick release-1.0 |
Collaborator
|
🤖 says: cherry pick action finished successfully 🎉! |
apecloud-bot
pushed a commit
that referenced
this pull request
Aug 4, 2025
(cherry picked from commit b63d94b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.