Conversation
|
Auto Cherry-pick Instructions |
|
/nopick |
0f9f3f1 to
d169a30
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9546 +/- ##
==========================================
- Coverage 59.94% 59.62% -0.32%
==========================================
Files 518 551 +33
Lines 56636 59931 +3295
==========================================
+ Hits 33948 35734 +1786
- Misses 19636 20936 +1300
- Partials 3052 3261 +209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d169a30 to
688d714
Compare
6154703 to
f9cfcae
Compare
428a60d to
611875e
Compare
611875e to
784684f
Compare
784684f to
3f2d28d
Compare
|
What's the main advantage of introducing the new instance api? |
| } | ||
| } | ||
|
|
||
| // TODO: ??? |
There was a problem hiding this comment.
The code was introduced by #8151. I think it's still useful.
There was a problem hiding this comment.
It is not supported within the instance API.
| } | ||
| return true | ||
| case []corev1.Toleration: | ||
| return true |
There was a problem hiding this comment.
Why are tolerations ignored?
edd75f5 to
532f11a
Compare
532f11a to
a0aeedb
Compare
The Instance API enables consolidated management of resources and states associated with a single replica – some of which are currently scattered across different controllers. This in turn simplifies the management of replicas across multiple k8s clusters. |
|
/approve |
No description provided.