Skip to content

chore: introduce the instance crd#9546

Merged
leon-inf merged 32 commits intomainfrom
support/instance-crd
Aug 26, 2025
Merged

chore: introduce the instance crd#9546
leon-inf merged 32 commits intomainfrom
support/instance-crd

Conversation

@leon-inf
Copy link
Copy Markdown
Contributor

No description provided.

@leon-inf leon-inf added this to the Release 1.1.0 milestone Jul 17, 2025
@apecloud-bot
Copy link
Copy Markdown
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Jul 17, 2025
@leon-inf
Copy link
Copy Markdown
Contributor Author

/nopick

@apecloud-bot apecloud-bot added the nopick Not auto cherry-pick when PR merged label Jul 17, 2025
@leon-inf leon-inf force-pushed the support/instance-crd branch from 0f9f3f1 to d169a30 Compare July 17, 2025 08:37
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 17, 2025

Codecov Report

❌ Patch coverage is 54.61821% with 1361 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.62%. Comparing base (f8afb5a) to head (532f11a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...controller/instance/reconciler_assistant_object.go 6.75% 136 Missing and 2 partials ⚠️
pkg/controller/builder/builder_instance.go 0.00% 117 Missing ⚠️
.../controller/instanceset2/assistant_object_utils.go 6.61% 112 Missing and 1 partial ⚠️
pkg/controller/instance/in_place_update_utils.go 52.13% 88 Missing and 24 partials ⚠️
pkg/controller/instanceset2/instance_util.go 57.25% 92 Missing and 17 partials ⚠️
pkg/controller/instance/utils.go 60.16% 81 Missing and 15 partials ⚠️
pkg/controller/instanceset2/update_plan.go 43.57% 76 Missing and 3 partials ⚠️
pkg/controller/instanceset2/reconciler_status.go 74.43% 51 Missing and 17 partials ⚠️
pkg/controller/instance/reconciler_update.go 60.86% 45 Missing and 18 partials ⚠️
pkg/controller/instance/pod_role_event_handler.go 10.44% 60 Missing ⚠️
... and 25 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9546      +/-   ##
==========================================
- Coverage   59.94%   59.62%   -0.32%     
==========================================
  Files         518      551      +33     
  Lines       56636    59931    +3295     
==========================================
+ Hits        33948    35734    +1786     
- Misses      19636    20936    +1300     
- Partials     3052     3261     +209     
Flag Coverage Δ
unittests 59.62% <54.61%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leon-inf leon-inf force-pushed the support/instance-crd branch from d169a30 to 688d714 Compare July 17, 2025 08:56
@leon-inf leon-inf force-pushed the support/instance-crd branch 11 times, most recently from 6154703 to f9cfcae Compare July 22, 2025 05:57
@leon-inf leon-inf force-pushed the support/instance-crd branch 4 times, most recently from 428a60d to 611875e Compare August 8, 2025 09:21
@leon-inf leon-inf marked this pull request as ready for review August 8, 2025 09:23
@leon-inf leon-inf requested a review from a team as a code owner August 8, 2025 09:23
@leon-inf leon-inf force-pushed the support/instance-crd branch from 611875e to 784684f Compare August 8, 2025 10:01
@leon-inf leon-inf force-pushed the support/instance-crd branch from 784684f to 3f2d28d Compare August 8, 2025 10:08
@cjc7373
Copy link
Copy Markdown
Contributor

cjc7373 commented Aug 13, 2025

What's the main advantage of introducing the new instance api?

}
}

// TODO: ???
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code was introduced by #8151. I think it's still useful.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not supported within the instance API.

}
return true
case []corev1.Toleration:
return true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are tolerations ignored?

@leon-inf leon-inf force-pushed the support/instance-crd branch 3 times, most recently from edd75f5 to 532f11a Compare August 22, 2025 07:37
@leon-inf leon-inf force-pushed the support/instance-crd branch from 532f11a to a0aeedb Compare August 22, 2025 08:44
@apecloud-bot apecloud-bot added the approved PR Approved Test label Aug 25, 2025
@leon-inf
Copy link
Copy Markdown
Contributor Author

What's the main advantage of introducing the new instance api?

The Instance API enables consolidated management of resources and states associated with a single replica – some of which are currently scattered across different controllers. This in turn simplifies the management of replicas across multiple k8s clusters.

@leon-inf
Copy link
Copy Markdown
Contributor Author

/approve

@leon-inf leon-inf merged commit 19589e6 into main Aug 26, 2025
63 of 68 checks passed
@leon-inf leon-inf deleted the support/instance-crd branch September 2, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test nopick Not auto cherry-pick when PR merged size/XXL Denotes a PR that changes 1000+ lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants