Conversation
|
Auto Cherry-pick Instructions |
|
/nopick |
4aebbc4 to
34cc7c5
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10067 +/- ##
==========================================
+ Coverage 51.06% 51.20% +0.13%
==========================================
Files 539 539
Lines 58951 58975 +24
==========================================
+ Hits 30104 30198 +94
+ Misses 25877 25824 -53
+ Partials 2970 2953 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
| objs[obj.Name] = obj | ||
|
|
||
| configHash := obj.Annotations[constant.CMInsConfigurationHashLabelKey] |
There was a problem hiding this comment.
Looks like this annotation is unnecessary, using tpl.ConfigHash is enough?
There was a problem hiding this comment.
I also wonder why ClusterComponentConfig.ConfigHash is needed? Would a user or a controller need to use this field?
There was a problem hiding this comment.
I also wonder why ClusterComponentConfig.ConfigHash is needed? Would a user or a controller need to use this field?
Chech #10064 for the usage of configHash.
34cc7c5 to
0e9e7be
Compare
|
/approve |
No description provided.