Skip to content

chore: add restart to ITS config API#10067

Merged
leon-ape merged 3 commits intomainfrom
support/its-config-api
Mar 4, 2026
Merged

chore: add restart to ITS config API#10067
leon-ape merged 3 commits intomainfrom
support/its-config-api

Conversation

@leon-ape
Copy link
Contributor

@leon-ape leon-ape commented Mar 4, 2026

No description provided.

@leon-ape leon-ape added this to the Release 1.2.0 milestone Mar 4, 2026
@leon-ape leon-ape requested a review from kizuna-lek March 4, 2026 05:14
@leon-ape leon-ape requested a review from a team as a code owner March 4, 2026 05:14
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Mar 4, 2026
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

@leon-ape
Copy link
Contributor Author

leon-ape commented Mar 4, 2026

/nopick

@apecloud-bot apecloud-bot added the nopick Not auto cherry-pick when PR merged label Mar 4, 2026
@leon-ape leon-ape force-pushed the support/its-config-api branch from 4aebbc4 to 34cc7c5 Compare March 4, 2026 05:35
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 58.33333% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.20%. Comparing base (72097f8) to head (2b08ae1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/instanceset/reconciler_update.go 0.00% 6 Missing ⚠️
pkg/controllerutil/encryption.go 45.45% 4 Missing and 2 partials ⚠️
...s/apps/component/transformer_component_template.go 62.50% 2 Missing and 1 partial ⚠️
apis/apps/v1/deprecated.go 0.00% 2 Missing ⚠️
...ps/component/transformer_component_workload_ops.go 83.33% 0 Missing and 1 partial ⚠️
pkg/controller/instanceset/reconciler_status.go 0.00% 1 Missing ⚠️
pkg/controller/instanceset2/reconciler_status.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10067      +/-   ##
==========================================
+ Coverage   51.06%   51.20%   +0.13%     
==========================================
  Files         539      539              
  Lines       58951    58975      +24     
==========================================
+ Hits        30104    30198      +94     
+ Misses      25877    25824      -53     
+ Partials     2970     2953      -17     
Flag Coverage Δ
unittests 51.20% <58.33%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Mar 4, 2026
}
objs[obj.Name] = obj

configHash := obj.Annotations[constant.CMInsConfigurationHashLabelKey]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this annotation is unnecessary, using tpl.ConfigHash is enough?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also wonder why ClusterComponentConfig.ConfigHash is needed? Would a user or a controller need to use this field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also wonder why ClusterComponentConfig.ConfigHash is needed? Would a user or a controller need to use this field?

Chech #10064 for the usage of configHash.

@leon-ape leon-ape force-pushed the support/its-config-api branch from 34cc7c5 to 0e9e7be Compare March 4, 2026 07:52
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Mar 4, 2026
@apecloud-bot apecloud-bot added the approved PR Approved Test label Mar 4, 2026
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Mar 4, 2026
@leon-ape
Copy link
Contributor Author

leon-ape commented Mar 4, 2026

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Mar 4, 2026
@leon-ape leon-ape merged commit 1dc89b3 into main Mar 4, 2026
38 checks passed
@leon-ape leon-ape deleted the support/its-config-api branch March 4, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR Approved Test nopick Not auto cherry-pick when PR merged size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants